Conversation
Contributor
Author
|
@nddipiazza , I'm hesitant to merge this because of all the exclusions in the grpc pom for this artifact. We need it for javadoc-aggregate. Does it hurt grpc to include it? There's no rush on this...sometime before we have to generate javadocs again. LOL... Thank you! |
Contributor
Author
|
@nddipiazza I needed this for javadocs. Please undo if I'm breaking anything in grpc. |
tballison
added a commit
that referenced
this pull request
Oct 2, 2025
(cherry picked from commit 3c0dab1)
Lineaje-DepFixer
added a commit
to lineaje-labs-gos/tika
that referenced
this pull request
Oct 29, 2025
Add errorprone dependency back in tika-grpc to fix tests (apache#2224)
abhiseksanyal
pushed a commit
to lineaje-labs-gos/tika
that referenced
this pull request
Oct 29, 2025
Add errorprone dependency back in tika-grpc to fix tests (apache#2224)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we run
javadoc:aggregate, this dependency is needed. Would it cause problems if we added it? Do we need to exclude it from the other grpc dependencies where we're currently excluding it?Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)mvn clean testmainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!