Skip to content

add errorprone back in#2224

Merged
tballison merged 1 commit intomainfrom
TIKA-4318
Oct 2, 2025
Merged

add errorprone back in#2224
tballison merged 1 commit intomainfrom
TIKA-4318

Conversation

@tballison
Copy link
Contributor

When we run javadoc:aggregate, this dependency is needed. Would it cause problems if we added it? Do we need to exclude it from the other grpc dependencies where we're currently excluding it?

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika is successfully built and unit tests pass by running mvn clean test
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

@tballison tballison requested a review from nddipiazza May 29, 2025 20:03
@tballison
Copy link
Contributor Author

@nddipiazza , I'm hesitant to merge this because of all the exclusions in the grpc pom for this artifact. We need it for javadoc-aggregate. Does it hurt grpc to include it?

There's no rush on this...sometime before we have to generate javadocs again. LOL...

Thank you!

@tballison
Copy link
Contributor Author

@nddipiazza I needed this for javadocs. Please undo if I'm breaking anything in grpc.

@tballison tballison merged commit 3c0dab1 into main Oct 2, 2025
1 check passed
@tballison tballison deleted the TIKA-4318 branch October 2, 2025 19:29
tballison added a commit that referenced this pull request Oct 2, 2025
(cherry picked from commit 3c0dab1)
Lineaje-DepFixer added a commit to lineaje-labs-gos/tika that referenced this pull request Oct 29, 2025
Add errorprone dependency back in tika-grpc to fix tests (apache#2224)
abhiseksanyal pushed a commit to lineaje-labs-gos/tika that referenced this pull request Oct 29, 2025
Add errorprone dependency back in tika-grpc to fix tests (apache#2224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant